Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd: hide --sort-dir in changefeed command. (deprecated warning exists) (#1784) #1794

Merged
merged 4 commits into from
May 19, 2021
Merged

cmd: hide --sort-dir in changefeed command. (deprecated warning exists) (#1784) #1794

merged 4 commits into from
May 19, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1784

What problem does this PR solve?

Hide --sort-dir in changefeed command

What is changed and how it works?

  • Hide --sort-dir in changefeed command
  • Set SortDir to `json:"-"` in changefeed, so the changefeed query won't print any sort-dir which may confuse user. Note only set it to an ignore field is backward compatibility

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

@ti-chi-bot ti-chi-bot mentioned this pull request May 19, 2021
Merged
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. do-not-merge/cherry-pick-not-approved labels May 19, 2021
@ti-chi-bot ti-chi-bot requested review from amyangfei and zier-one May 19, 2021 04:38
@amyangfei amyangfei added this to the v4.0.13 milestone May 19, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 19, 2021
lonng
lonng reviewed May 19, 2021
View reviewed changes
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • lonng

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 19, 2021
@lonng lonng added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 19, 2021
@lonng
Copy link
Contributor

lonng commented May 19, 2021

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 3782274

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 19, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1794 (9ebcc08) into release-4.0 (753073a) will decrease coverage by 1.2601%.
The diff coverage is 53.2448%.

❗ Current head 9ebcc08 differs from pull request most recent head e72abd7. Consider uploading reports for the commit e72abd7 to get more accurate results

@@                 Coverage Diff                 @@
##           release-4.0      #1794        +/-   ##
===================================================
- Coverage      53.7661%   52.5059%   -1.2602%     
===================================================
  Files              153        153                
  Lines            15958      15922        -36     
===================================================
- Hits              8580       8360       -220     
- Misses            6475       6651       +176     
- Partials           903        911         +8

@amyangfei
Copy link
Contributor

/run-all-tests

@amyangfei
Copy link
Contributor

/run-unit-tests

@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@amyangfei
Copy link
Contributor

/run-leak-tests

@ti-chi-bot ti-chi-bot merged commit bccc2fe into pingcap:release-4.0 May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonng lonng lonng left review comments

@amyangfei amyangfei amyangfei approved these changes

@zier-one zier-one Awaiting requested review from zier-one

Assignees

@amyangfei amyangfei

Labels
cherry-pick-approved Cherry pick PR approved by release team. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.
Projects
None yet
Milestone
v4.0.13
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @lonng @codecov-commenter @amyangfei